Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ext/node): add riscv64 in process.arch #23016

Merged
merged 1 commit into from Mar 21, 2024

Conversation

hack3ric
Copy link
Contributor

@hack3ric hack3ric commented Mar 21, 2024

Rust triple for riscv64 is riscv64gc. Although there are no official builds for architectures other than x86_64 and aarch64, Arch Linux RISC-V has managed to package Deno on riscv64: https://github.com/felixonmars/archriscv-packages/blob/master/deno/riscv64.patch

Ref: #18702

Rust triple for riscv64 is riscv64gc. Although there are no official builds for architectures other than x86_64 and aarch64, Arch Linux RISC-V has managed to package Deno on riscv64: https://github.com/felixonmars/archriscv-packages/blob/master/deno/riscv64.patch
hack3ric added a commit to hack3ric/archriscv-packages that referenced this pull request Mar 21, 2024
- Drop previous V8 patch, backport https://chromium-review.googlesource.com/c/chromium/src/+/4974179 to fix missing GN variables
- Add riscv64 in process.arch. Upstreamed to denoland/deno#23016
- Existing crate version bumps upstreamed to denoland/deno#23015
felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request Mar 21, 2024
- Drop previous V8 patch, backport https://chromium-review.googlesource.com/c/chromium/src/+/4974179 to fix missing GN variables
- Add riscv64 in process.arch. Upstreamed to denoland/deno#23016
- Existing crate version bumps upstreamed to denoland/deno#23015
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit 976fa48 into denoland:main Mar 21, 2024
17 checks passed
@hack3ric hack3ric deleted the arch-riscv64 branch March 21, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants