Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(install): require -g / --global flag #23060

Merged
merged 10 commits into from Mar 27, 2024

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Mar 24, 2024

In preparation for upcoming changes to deno install in Deno 2.

If -g or --global flag is not provided a warning will be emitted:

⚠️ `deno install` behavior will change in Deno 2. To preserve the current behavior use `-g` or `--global` flag.

The same will happen for deno uninstall - unless -g/--global flag is provided
a warning will be emitted.

Towards #23062

@bartlomieju bartlomieju added this to the 1.42 milestone Mar 24, 2024
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cli/args/flags.rs Outdated Show resolved Hide resolved
cli/tools/installer.rs Outdated Show resolved Hide resolved
cli/tools/installer.rs Outdated Show resolved Hide resolved
tests/integration/install_tests.rs Show resolved Hide resolved
bartlomieju and others added 7 commits March 27, 2024 22:28
Co-authored-by: David Sherret <dsherret@users.noreply.github.com>
Signed-off-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Co-authored-by: David Sherret <dsherret@users.noreply.github.com>
Signed-off-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Co-authored-by: David Sherret <dsherret@users.noreply.github.com>
Signed-off-by: Bartek Iwańczuk <biwanczuk@gmail.com>
@bartlomieju bartlomieju merged commit d31f230 into denoland:main Mar 27, 2024
17 checks passed
@bartlomieju bartlomieju deleted the deno_install_global branch March 27, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants