-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: v8 code cache #23081
Merged
Merged
perf: v8 code cache #23081
Changes from 10 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
315dcaa
feat(cli): v8 code cache
igorzi e27abee
review comments
igorzi 0d835ed
Merge branch 'main' into code_cache
igorzi 0b117e3
don't use code cache for coverage runs
igorzi 8d7d614
fix tests
igorzi d1dc979
Merge branch 'main' into code_cache
igorzi 6d43f0a
include hash and timestamp into code cache
igorzi 74b8bb0
enable only for deno run
igorzi 33e1df4
Merge branch 'main' into code_cache
igorzi 05d6d18
fixes
igorzi ef2b573
more fixes
igorzi 372d2b7
fix args tests
igorzi 6e73812
update sql query
igorzi 792c441
Merge branch 'code_cache'
igorzi 9e33050
fix tests on windows
igorzi 99ceea8
fix timing test issue on windows
igorzi bcdb3dc
Merge branch 'main' into code_cache
bartlomieju a6c297b
more fixes
igorzi 28e1fdd
fix wpt
igorzi 9086f0b
move test
igorzi 2ae4745
add npm tests
igorzi cbb2237
revert test timeout
igorzi ae14b42
bring back larger test timeout
igorzi File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have negative-sense flags in this flags struct -- see
no_npm
,no_prompt
, etc. It would simplify the test changes required for this file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately big test change will still be needed in this file because we're only enabling code cache for
run
command initially.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up keeping this the same. With the negative
no_code_cache
flag there are actually more test changes needed (because code cache is disabled for non-run commands).