New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: type declarations for new Set methods #23090

Merged

dsherret merged 1 commit into denoland:main from dsherret:feat_tsc_set_methods

Mar 27, 2024

Member

dsherret commented Mar 27, 2024

Closes #22851


          feat: type declarations for new Set methods

00aa0db

dsherret commented

View reviewed changes

cli/tsc/dts/lib.esnext.collection.d.ts

+                  /**
+                   * @returns a new Set containing all the elements in this Set and also all the elements in the argument.
+                   */
+                  union<U>(other: Set<U>): Set<T | U>;

Member Author

dsherret Mar 27, 2024

We've made this specific to Set rather than a "read-only set" to avoid creating a global until this has landed in typescript.

See #22851 (comment)

bartlomieju approved these changes

View reviewed changes

dsherret merged commit 34a651e into denoland:main

17 checks passed

dsherret deleted the feat_tsc_set_methods branch

March 27, 2024 01:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment