Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(check): do not suggest running with --unstable #23092

Merged

Conversation

dsherret
Copy link
Member

Closes #23079

Copy link
Contributor

@irbull irbull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not sure if I can actually approve 😄 )

@@ -0,0 +1,10 @@
Check file:///[WILDLINE]main.ts
error: TS2551 [ERROR]: Property 'dlopen' does not exist on type 'typeof Deno'. Did you mean 'open'? 'Deno.dlopen' is an unstable API. Did you mean 'open'? If not, try changing the 'lib' compiler option to include 'deno.unstable' or add a triple-slash directive to the top of your entrypoint (main file): /// <reference lib="deno.unstable" />
Copy link
Contributor

@irbull irbull Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll assume this was generated and you C&P it here. TS2551 does appear to be the correct TS Error, but I'm not sure where these are defined. 👍

@dsherret dsherret merged commit 49f97d5 into denoland:main Mar 27, 2024
17 checks passed
@dsherret dsherret deleted the fix_ts_do_not_suggest_running_with_unstable branch March 27, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing unstable types incorrectly suggests running with --unstable
3 participants