feat(runtime): Allow embedders to perform additional access checks on file open #23208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
force-pushed
the
combine_read_write
branch
13 times, most recently
from
5a0104d
to
09b355e
Compare
mmastrac
force-pushed
the
combine_read_write
branch
2 times, most recently
from
d3cb8cf
to
dc74c8c
Compare
mmastrac
force-pushed
the
combine_read_write
branch
from
dc74c8c
to
806bf4f
Compare
…into combine_read_write
bartlomieju
approved these changes
Apr 18, 2024
Comment on lines
+1658
to
+1660
| pub fn check_was_allow_all_flag_passed(&mut self) -> Result<(), AnyError> { | ||
| self.0.lock().all.check() | ||
| } |
There was a problem hiding this comment.
Might be good to have a unit test for this one
There was a problem hiding this comment.
Adding this to a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embedders may have special requirements around file opening, so we add a new
check_openpermission check that is called as part of the file open process.