Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't expose deno_buf from core #2324

Merged
merged 2 commits into from May 9, 2019
Merged

Conversation

bartlomieju
Copy link
Member

Closes #2076.

I also modified comment that was outdated.

@ry
Copy link
Member

ry commented May 9, 2019

Thanks! Can you also include this change:

commit 6e3b442ddcd6cda997930540577f6390ee7f8ccf
Author: Ryan Dahl <ry@tinyclouds.org>
Date:   Thu May 9 10:20:34 2019 -0400

    core: Privatize ModuleNameMap and SymbolicModule

diff --git a/core/modules.rs b/core/modules.rs
index 0e7cc68a..0fb3147c 100644
--- a/core/modules.rs
+++ b/core/modules.rs
@@ -305,7 +305,7 @@ impl ModuleInfo {
 }
 
 /// A symbolic module entity.
-pub enum SymbolicModule {
+enum SymbolicModule {
   /// This module is an alias to another module.
   /// This is useful such that multiple names could point to
   /// the same underlying module (particularly due to redirects).
@@ -316,7 +316,7 @@ pub enum SymbolicModule {
 
 #[derive(Default)]
 /// Alias-able module name map
-pub struct ModuleNameMap {
+struct ModuleNameMap {
   inner: HashMap<String, SymbolicModule>,
 }
 

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 1fc61f3 into denoland:master May 9, 2019
@bartlomieju bartlomieju deleted the private_deno_buf branch May 9, 2019 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core should not export "deno_buf"
2 participants