WIP: op_get_random_values

cli/BUILD.gn

@@ -77,6 +77,7 @@ ts_sources = [
   "../js/files.ts",
   "../js/flatbuffers.ts",
   "../js/form_data.ts",
+  "../js/get_random_values.ts",
   "../js/globals.ts",
   "../js/headers.ts",
   "../js/io.ts",

cli/main.rs

@@ -11,6 +11,7 @@ extern crate clap;
 extern crate deno;
 #[cfg(unix)]
 extern crate nix;
+extern crate rand;
 
 mod ansi;
 pub mod compiler;

cli/msg.fbs

@@ -19,6 +19,7 @@ union Any {
   FetchRes,
   FormatError,
   FormatErrorRes,
+  GetRandomValues,
   GlobalTimer,
   GlobalTimerRes,
   GlobalTimerStop,
@@ -579,4 +580,6 @@ table Seek {
   whence: uint;
 }
 
+table GetRandomValues {}
+
 root_type Base;

cli/ops.rs

@@ -13,6 +13,7 @@ use crate::js_errors::apply_source_map;
 use crate::js_errors::JSErrorColor;
 use crate::msg;
 use crate::msg_util;
+use crate::rand;
 use crate::repl;
 use crate::resolve_addr::resolve_addr;
 use crate::resources;
@@ -39,6 +40,7 @@ use futures::Sink;
 use futures::Stream;
 use hyper;
 use hyper::rt::Future;
+use rand::{thread_rng, Rng};
 use remove_dir_all::remove_dir_all;
 use std;
 use std::convert::From;
@@ -195,6 +197,7 @@ pub fn op_selector_std(inner_type: msg::Any) -> Option<OpCreator> {
     msg::Any::Exit => Some(op_exit),
     msg::Any::Fetch => Some(op_fetch),
     msg::Any::FormatError => Some(op_format_error),
+    msg::Any::GetRandomValues => Some(op_get_random_values),
     msg::Any::GlobalTimer => Some(op_global_timer),
     msg::Any::GlobalTimerStop => Some(op_global_timer_stop),
     msg::Any::IsTTY => Some(op_is_tty),
@@ -2182,3 +2185,13 @@ fn op_host_post_message(
   });
   Box::new(op)
 }
+
+fn op_get_random_values(
+  _state: &ThreadSafeState,
+  _base: &msg::Base<'_>,
+  data: Option<PinnedBuf>
+) -> Box<OpWithError> {
+  assert!(data.is_some());
+  thread_rng().fill(&mut data.unwrap()[..]);
+  Box::new(ok_future(empty_buf()))
+}

js/deno.ts

@@ -81,6 +81,7 @@ export {
 export { inspect } from "./console";
 export { build, platform, OperatingSystem, Arch } from "./build";
 export { version } from "./version";
+export { getRandomValues, getRandomValuesSync } from "./get_random_values";
 export const args: string[] = [];
 
 // These are internal Deno APIs.  We are marking them as internal so they do not

js/get_random_values.ts

@@ -0,0 +1,36 @@
+// Copyright 2018-2019 the Deno authors. All rights reserved. MIT license.
+import * as msg from "gen/cli/msg_generated";
+import * as flatbuffers from "./flatbuffers";
+import * as dispatch from "./dispatch";
+import { assert } from "./util";
+
+function req(
+  typedArray: ArrayBufferView
+): [flatbuffers.Builder, msg.Any, flatbuffers.Offset, ArrayBufferView] {
+  assert(typedArray != null);
+  const builder = flatbuffers.createBuilder();
+  const inner = msg.GetRandomValues.createGetRandomValues(builder);
+  return [builder, msg.Any.GetRandomValues, inner, typedArray];
+}
+
+/** Collects cryptographically secure random values. Throws if given anything
+ * but an ArrayBufferView. The underlying CSPRNG in use is Rust's
+ * `rand::rngs::ThreadRng`.
+ *
+ *       const arr = new Uint8Array(32);
+ *       await Deno.getRandomValues(arr);
+ */
+export async function getRandomValues(typedArray: ArrayBufferView): Promise<void> {
+  await dispatch.sendAsync(...req(typedArray));
+}
+
+/** Synchronously collects cryptographically secure random values. Throws if
+ * given anything but an ArrayBufferView. The underlying CSPRNG in use is Rust's
+ * `rand::rngs::ThreadRng`.
+ *
+ *       const arr = new Uint8Array(32);
+ *       Deno.getRandomValuesSync(arr);
+ */
+export function getRandomValuesSync(typedArray: ArrayBufferView): void {
+  dispatch.sendSync(...req(typedArray));
+}

js/get_random_values_test.ts

@@ -0,0 +1,33 @@
+// Copyright 2018-2019 the Deno authors. All rights reserved. MIT license.
+import { test, assertNotEquals } from "./test_util.ts";
+
+test(async function csprngBytes(): Promise<void> {
+  const arr = new Uint8Array(32);
+  await Deno.getRandomValues(arr);
+  assertNotEquals(arr, new Uint8Array(32));
+});
+
+test(async function csprngValues(): Promise<void> {
+  const arr = new Int16Array(4);
+  await Deno.getRandomValues(arr);
+  assertNotEquals(arr, new Int16Array(4));
+});
+
+test(async function csprngBigints(): Promise<void> {
+  const arr = new BigInt64Array(4);
+  await Deno.getRandomValues(arr);
+  assertNotEquals(arr, new BigInt64Array(4));
+});
+
+test(async function csprngGivenADataView(): Promise<void> {
+  const arr = new Int32Array(4);
+  const view = new DataView(arr.buffer);
+  await Deno.getRandomValues(view);
+  assertNotEquals(arr, new Int32Array(4));
+});
+
+test(function csprngValuesSync(): void {
+  const arr = new Uint32Array(8);
+  Deno.getRandomValuesSync(arr);
+  assertNotEquals(arr, new Uint32Array(8));
+});

js/unit_tests.ts

@@ -19,6 +19,7 @@ import "./fetch_test.ts";
 import "./file_test.ts";
 import "./files_test.ts";
 import "./form_data_test.ts";
+import "./get_random_values_test.ts";
 import "./globals_test.ts";
 import "./headers_test.ts";
 import "./link_test.ts";