feat(check): allow using side effect imports with unknown module kinds (ex. css modules) #23392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would this behavior be configurable? for projects not using bundlers like vite, this might introduce subtle import bugs that might be only be found on runtime |
@scarf005 Probably not. This change aligns more with TypeScript which already doesn't error for these kind of imports:
This branch in Deno is still more strict than TypeScript:
|
|
ah, so it will check for missing import. makes sense then. |
littledivy
pushed a commit
to littledivy/deno
that referenced
this pull request
Apr 19, 2024
…s (ex. css modules) (denoland#23392) This allows people to use imports like: ```ts import "./app.css"; ``` ...with `deno check` in systems where there's a bundle step (ex. Vite). This will still error when using it with `deno run` or if the referenced file does not exist. See test cases for behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows people to use imports like:
...with
deno checkin systems where there's a bundle step (ex. Vite). This will still error when using it withdeno runor if the referenced file does not exist.See test cases for behaviour.