feat(ext/http): Implement request.signal for Deno.serve #23425
Merged
+119
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
changed the title
bartlomieju
reviewed
Apr 17, 2024
| return async function (req) { | ||
| const abortController = new AbortController(); |
There was a problem hiding this comment.
Are we sure we want to create one unconditionally?
There was a problem hiding this comment.
I don't have a great way to do this conditionally right now -- we'd have to refactor Request a bit for that. For now, impact seems small (not zero).
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ext/http/00_serve.ts
Outdated
Comment on lines
287
to
293
| if (!this.#completed) { | ||
| this.#completed = Promise.withResolvers<void>(); | ||
| } | ||
| return this.#completed.promise; |
ext/http/00_serve.ts
Outdated
Comment on lines
541
to
554
| let options: { | ||
| port?: number; | ||
| hostname?: string; | ||
| signal?: AbortSignal; | ||
| reusePort?: boolean; | ||
| key?: string; | ||
| cert?: string; | ||
| onError?: (error: unknown) => Response | Promise<Response>; | ||
| onListen?: (params: { hostname: string; port: number }) => void; | ||
| handler?: ( | ||
| request: Request, | ||
| info: ServeHandlerInfo, | ||
| ) => Response | Promise<Response>; | ||
| } | undefined; |
There was a problem hiding this comment.
Since you are changing this file to be TS consider factoring this out to be an interface outside this function. Gonna be a lot easier to read and parse
Comment on lines
-33
to
-36
| /// Stream provided trailers. | ||
| // TODO(mmastrac): We are threading trailers through the response system to eventually support Grpc. | ||
| #[allow(unused)] | ||
| Trailers(HeaderMap), |
There was a problem hiding this comment.
It was unused -- we ended up doing trailers a different way 🙃
mmastrac
changed the title
bartlomieju
approved these changes
Apr 24, 2024
This was referenced Apr 24, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the response has been successfully send, we abort the
Request.signalproperty to indicate that all resources associated with this transaction may be torn down.