Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Don't panic on invalid emit options #23463

Merged
merged 3 commits into from
Apr 23, 2024
Merged

fix(cli): Don't panic on invalid emit options #23463

merged 3 commits into from
Apr 23, 2024

Conversation

nathanwhit
Copy link
Member

Fixes #23456.

bartlomieju
bartlomieju reviewed Apr 20, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you add an integration test to ensure the error is surfaced properly?

@nathanwhit nathanwhit merged commit 8a367d3 into denoland:main Apr 23, 2024
17 checks passed
@nathanwhit nathanwhit deleted the compiler-option-panic branch April 23, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Panic on invalid compilerOption values in deno.json
2 participants
@nathanwhit @bartlomieju