Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(task): support running npm binary commands in deno.json #23478

Merged
merged 1 commit into from
Apr 21, 2024
Merged

feat(task): support running npm binary commands in deno.json #23478

merged 1 commit into from
Apr 21, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Apr 20, 2024 •
edited
Loading

npm binary commands like vite from a node_modules/.bin folder will now execute when defined in a deno.json

Closes #23477

@dsherret dsherret added this to the 1.43 milestone Apr 20, 2024
bartlomieju
bartlomieju approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great to have it fixed. Can you measure the overhead this adds before landing?

@dsherret
Copy link
Member Author

Seems about the same.

@dsherret dsherret merged commit 695f314 into denoland:main Apr 21, 2024
17 checks passed
@dsherret dsherret deleted the feat_deno_json_npm_binary_commands branch April 21, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.43
Development

Successfully merging this pull request may close these issues.

task - Support running npm binary commands in a deno.json
2 participants
@dsherret @bartlomieju