Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "refactor(lsp): move fields from Documents to LspResolver" #23626

Merged
merged 1 commit into from
May 1, 2024

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented May 1, 2024

This reverts commit 5cae343.

image

Caused a +3.3s regression in one of the LSP benchmarks at deno.land/benchmarks.

Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy enabled auto-merge (squash) May 1, 2024 04:42
@littledivy littledivy merged commit 7f80d90 into denoland:main May 1, 2024
17 checks passed
@littledivy littledivy deleted the revert_lsp_regression_commit branch May 1, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants