fix(compile): relative permissions should be retained as relative #23719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
May 6, 2024
| @@ -134,7 +134,7 @@ pub enum NodeModules { | |||
| pub struct Metadata { | |||
| pub argv: Vec<String>, | |||
| pub seed: Option<u64>, | |||
| pub permissions: PermissionsOptions, | |||
| pub permissions: PermissionFlags, | |||
There was a problem hiding this comment.
Fix is here. Instead of storing the resolved PermissionsOptions we store the raw flags.
bartlomieju
approved these changes
May 6, 2024
| pub reload: bool, | ||
| pub seed: Option<u64>, | ||
| pub strace_ops: Option<Vec<String>>, | ||
| pub unstable_config: UnstableConfig, | ||
| pub unsafely_ignore_certificate_errors: Option<Vec<String>>, | ||
| pub v8_flags: Vec<String>, | ||
| pub code_cache_enabled: bool, | ||
| pub permissions: PermissionFlags, |
There was a problem hiding this comment.
That's a nice cleanup but I wish it was done in a separate PR, makes reviewing this one a lot harder.
Comment on lines
+3
to
+25
| "steps": [{ | ||
| "if": "unix", | ||
| "args": "compile --output=main --no-prompt --allow-read=a.txt main.ts", | ||
| "output": "[WILDCARD]" | ||
| }, { | ||
| "if": "unix", | ||
| "commandName": "./main", | ||
| "args": [], | ||
| "output": "No such file[WILDCARD]" | ||
| }, { | ||
| "if": "unix", | ||
| "args": [ | ||
| "eval", | ||
| "Deno.mkdirSync('sub_dir');" | ||
| ], | ||
| "output": "[WILDCARD]" | ||
| }, { | ||
| "if": "unix", | ||
| "commandName": "../main", | ||
| "cwd": "sub_dir", | ||
| "args": [], | ||
| "output": "No such file[WILDCARD]" | ||
| }] |
There was a problem hiding this comment.
Nice flex on what spec tests can do now :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23715