Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): make tarball extraction more reliable #23759

Merged
merged 9 commits into from
May 14, 2024

Conversation

dsherret
Copy link
Member

  1. Extracts to a directory beside the destination.
  2. Renames to the destination with retries.

cli/npm/managed/tarball.rs Outdated Show resolved Hide resolved
cli/npm/managed/cache.rs Outdated Show resolved Hide resolved
@dsherret dsherret merged commit f16b4d4 into denoland:main May 14, 2024
17 checks passed
@dsherret dsherret deleted the fix_npm_copy_temp_dir branch May 14, 2024 18:26
bartlomieju pushed a commit that referenced this pull request May 16, 2024
1. Extracts to a directory beside the destination.
2. Renames to the destination with retries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants