Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(task): various small refactorings #23793

Merged
merged 2 commits into from
May 13, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented May 13, 2024

This was from an exploration of launching deno task within a deno task in the same process (and looking to do that for npm run <script name>), but I think it's not feasible because to do it properly we'd have to maintain separate environments within a process. Anyway, figured we might as well keep some of these changes I did.

@dsherret dsherret requested a review from bartlomieju May 13, 2024 22:03
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cli/tools/task.rs Show resolved Hide resolved
@dsherret dsherret enabled auto-merge (squash) May 13, 2024 22:31
@dsherret dsherret merged commit f2dc3f9 into denoland:main May 13, 2024
17 checks passed
@dsherret dsherret deleted the chore_task_various_refactorings branch May 13, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants