fix(task): do not error if node_modules folder not exists

cli/npm/managed/resolvers/common.rs

@@ -9,6 +9,7 @@ use std::sync::Mutex;
 
 use async_trait::async_trait;
 use deno_ast::ModuleSpecifier;
+use deno_core::anyhow::Context;
 use deno_core::error::AnyError;
 use deno_core::futures;
 use deno_core::unsync::spawn;
@@ -94,9 +95,23 @@ impl RegistryReadPermissionChecker {
       let registry_path_canon = match cache.get(&self.registry_path) {
         Some(canon) => canon.clone(),
         None => {
-          let canon = self.fs.realpath_sync(&self.registry_path)?;
-          cache.insert(self.registry_path.to_path_buf(), canon.clone());
-          canon
+          match self.fs.realpath_sync(&self.registry_path) {
+            Ok(canon) => {
+              cache.insert(self.registry_path.to_path_buf(), canon.clone());
+              canon
+            }
+            Err(e) => {
+              if e.kind() == ErrorKind::NotFound {
+                return Ok(()); // root doesn't exist, so allow
+              }
+              return Err(AnyError::from(e)).with_context(|| {
+                format!(
+                  "failed canonicalizing '{}'",
+                  self.registry_path.display()
+                )
+              });
+            }
+          }
         }
       };
 

cli/tools/task.rs

@@ -70,7 +70,8 @@ pub async fn execute_script(
       bail!("Only local configuration files are supported")
     };
     let cwd = match task_flags.cwd {
-      Some(path) => canonicalize_path(&PathBuf::from(path))?,
+      Some(path) => canonicalize_path(&PathBuf::from(path))
+        .context("failed canonicalizing --cwd")?,
       None => config_file_path.parent().unwrap().to_owned(),
     };
 

tests/specs/task/node_modules_dir_false/__test__.jsonc

@@ -0,0 +1,16 @@
+{
+  "tempDir": true,
+  "steps": [{
+    "args": "cache npm:@denotest/esm-basic",
+    "output": "[WILDCARD]"
+  }, {
+    "args": [
+      "eval",
+      "Deno.removeSync('./node_modules', { recursive: true });"
+    ],
+    "output": "[WILDCARD]"
+  }, {
+    "args": "task --quiet repro",
+    "output": "hi\n"
+  }]
+}

tests/specs/task/node_modules_dir_false/deno.json

@@ -0,0 +1,6 @@
+{
+  "nodeModulesDir": true,
+  "tasks": {
+    "repro": "echo hi"
+  }
+}