Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewirte console constructor #2649

Merged
merged 1 commit into from Jul 17, 2019
Merged

rewirte console constructor #2649

merged 1 commit into from Jul 17, 2019

Conversation

justjavac
Copy link
Contributor

bartlomieju
bartlomieju approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @justjavac

ry
ry approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 181cfc9 into denoland:master Jul 17, 2019
@justjavac justjavac deleted the console-constructor branch July 18, 2019 00:15
@bartlomieju bartlomieju mentioned this pull request Sep 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justjavac @ry @bartlomieju