Implement function convertLineEndingsToNative in blob.ts #2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qti3e
reviewed
Jul 31, 2019
js/blob.ts
Outdated
| let token = collectionResult.collected; | ||
| position = collectionResult.newPosition; | ||
|
|
||
| result = result + token; |
There was a problem hiding this comment.
result is an empty string, no need to use it.
Suggested change
| result = result + token; | |
| result = token; |
js/blob.ts
Outdated
| token = collectionResult.collected; | ||
| position = collectionResult.newPosition; | ||
|
|
||
| result = result + token; |
There was a problem hiding this comment.
Suggested change
| result = result + token; | |
| result += token; |
js/blob.ts
Outdated
| } | ||
| } else if (c == "\n") { | ||
| position++; | ||
| result = result + nativeLineEnd; |
There was a problem hiding this comment.
Suggested change
| result = result + nativeLineEnd; | |
| result += nativeLineEnd; |
js/blob.ts
Outdated
| while (position < s.length) { | ||
| let c = s.charAt(position); | ||
| if (c == "\r") { | ||
| result = result + nativeLineEnd; |
There was a problem hiding this comment.
Suggested change
| result = result + nativeLineEnd; | |
| result += nativeLineEnd; |
js/blob.ts
Outdated
| // TODO(qti3e) Implement convertLineEndingsToNative. | ||
| // https://w3c.github.io/FileAPI/#convert-line-endings-to-native | ||
| return s; | ||
| let nativeLineEnd = "\n"; |
There was a problem hiding this comment.
Suggested change
| let nativeLineEnd = "\n"; | |
| let nativeLineEnd = build.os == "win" ? "\r\n" : "\n"; |
js/blob.ts
Outdated
| if (c == "\r" || c == "\n") { | ||
| break; | ||
| } | ||
| result = result.concat(c); |
There was a problem hiding this comment.
There is no need to do this call on every iteration, you can obtain the same result using slice() at the end.
const start = position;
while (...) { ... }
return { collected: s.slice(start, position), newPosition: position };I would probably use something like this:
function collectSequenceNotCRLF(s, position) {
const start = position;
for (
let c = s.charAt(position);
position < s.length && !(c == '\r' || c == '\n');
c = s.charAt(++position)
);
return { newPosition: position, collected: s.slice(start, position) };
}
|
👌 |
|
✌ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the function of convertLineEndingsToNative in blob.ts based on next URL.
https://w3c.github.io/FileAPI/#convert-line-endings-to-native