Use web standard Permissions API #3200
Conversation
| export class PermissionStatus { | ||
| state: PermissionState; | ||
| constructor(state: PermissionState); | ||
| } |
There was a problem hiding this comment.
Could you duplicate the jsdoc comments here?
(We need to fix this situation soon...)
| assertEquals(perms[perm], perm === grant); | ||
| } | ||
| testPerm({ [grant]: true }, async function envGranted(): Promise<void> { | ||
| const status0 = await Deno.permissions.query({ name: grant }); |
There was a problem hiding this comment.
Should we not just start using the global Permissions object?
There was a problem hiding this comment.
OK. Let's move permissions under navigator and other classes to global.
There was a problem hiding this comment.
Maybe leave it for separate PR since it is apparently controversial
There was a problem hiding this comment.
Sorry I misread the thread. OK. Let's keep it for now.
cli/js/permissions.ts
Outdated
| url?: string; | ||
| path?: string; |
There was a problem hiding this comment.
Why not use sub types for these?
interface PermissionDescriptor {
name: PermissionName;
}
namespace Deno {
export interface NetPermissionDescriptor extends PermissionDescriptor {
name: "net";
url?: string;
}
// ...
}There was a problem hiding this comment.
Thanks! That looks nicer. I'll update.
|
Like I said here #2767 (comment), putting this in What about this is supposed to work outside of deno anyway? 🙄 Happened with |
cli/js/permissions.ts
Outdated
| type PermissionDescriptor = | ||
| | SimplePermissionDescriptor | ||
| | PathPermissionDescriptor | ||
| | NetPermissionDescriptor; |
There was a problem hiding this comment.
👍
Opinion: I think it would be better to give each permission its own interface so they are arbitrarily extensible e.g. #3137.
Maybe read/write have a meaningful commonality but the rest aren't related to each other.
There was a problem hiding this comment.
Makes sense 👍 I separated descriptor types for each permission.
|
|
||
| export class Permissions { | ||
| query(d: PermissionDescriptor): Promise<PermissionStatus>; | ||
| revoke(d: PermissionDescriptor): Promise<PermissionStatus>; |
There was a problem hiding this comment.
It would be nice to have jsdoc with examples for these, since the previous API did have nice docs.
There was a problem hiding this comment.
Looking good. There's one more documentation change needed https://deno.land/std/manual.md#inspecting-and-revoking-permissions
|
Thank you for catching. Updated //std/manual.md. |
This PR changes the current permissions API to the web standard Permissions API.
ref:
Partially addresses #2767.