Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Improve path handling in permission checks #3714

Merged
merged 1 commit into from Jan 20, 2020
Merged

refactor: Improve path handling in permission checks #3714

merged 1 commit into from Jan 20, 2020

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Jan 19, 2020 •
edited

Uses Path instead of String/str for read/write permission APIs. resolve_from_cwd() as used in fs ops can just return a Path instead of a tuple.

The whitelists still store paths as Strings because of some memory issue.

@nayeemrmn nayeemrmn requested a review from ry January 19, 2020 12:08
ry
ry approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 7f80f9d into denoland:master Jan 20, 2020
@nayeemrmn nayeemrmn deleted the path-handling branch January 31, 2020 03:16
@nayeemrmn nayeemrmn mentioned this pull request Feb 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nayeemrmn @ry