Adjust dprint configuration to be closer to prettier #3824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Jan 30, 2020
|
@dsherret How about an option / change in behaviour for new lines in empty blocks? function f() {}
// Shouldn't turn into:
// function f() {
// } |
|
@nayeemrmn I do that for expressions right now, but not declarations. I was actually thinking about changing that to just be left alone yesterday. I don't know if that needs to be a configuration value and leaving declarations alone in that case is probably not a big deal. Generally I prefer to leave certain things up to the developer so I've opened https://github.com/dsherret/dprint/issues/65 |
nayeemrmn
reviewed
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge on approval