Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite normalize_path #4143

Merged
merged 3 commits into from Feb 26, 2020
Merged

rewrite normalize_path #4143

merged 3 commits into from Feb 26, 2020

Conversation

bartlomieju
Copy link
Member

Closes #4133

CC @piscisaureus

@piscisaureus piscisaureus self-requested a review February 26, 2020 20:30
piscisaureus
piscisaureus approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Maybe consider making the commit message a bit more descriptive.

@bartlomieju bartlomieju merged commit daf7617 into denoland:master Feb 26, 2020
@bartlomieju bartlomieju deleted the normalize_path_components branch February 26, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace PathBuf.canonicalize() with removal of "./" and "../" parts
2 participants
@bartlomieju @piscisaureus