Add require-await lint rule #4401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nayeemrmn
reviewed
Mar 17, 2020
cli/js/permissions.ts
Outdated
Comment on lines
50
to
62
| async query(desc: PermissionDescriptor): Promise<PermissionStatus> { | ||
| query(desc: PermissionDescriptor): PermissionStatus { | ||
| const state = permissionsOps.query(desc); | ||
| return new PermissionStatus(state); | ||
| } | ||
|
|
||
| async revoke(desc: PermissionDescriptor): Promise<PermissionStatus> { | ||
| revoke(desc: PermissionDescriptor): PermissionStatus { | ||
| const state = permissionsOps.revoke(desc); | ||
| return new PermissionStatus(state); | ||
| } | ||
|
|
||
| async request(desc: PermissionDescriptor): Promise<PermissionStatus> { | ||
| request(desc: PermissionDescriptor): PermissionStatus { | ||
| const state = permissionsOps.request(desc); | ||
| return new PermissionStatus(state); |
There was a problem hiding this comment.
Wrap the return types here in Promise.resolve().
added 6 commits
March 17, 2020 22:28
|
@samrith-s so far so good! |
|
@samrith-s thank you for this cumbersome work! I fixed some tests and reverted a few changes that weren't necessary. |
You’re welcome! I got stuck trying to fix these errors. Thank you so much for stepping in. |
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 21, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
require-awaitin linting rule to fix #4394.