Adds js/unit_tests.ts #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
force-pushed
the
tests_ts
branch
5 times, most recently
from
cf82cef
to
badda40
Compare
ry
force-pushed
the
tokio_timers
branch
2 times, most recently
from
8551164
to
1fcc498
Compare
This was referenced Aug 9, 2018
Closed
piscisaureus
approved these changes
Aug 9, 2018
js/testing/util.ts
Outdated
| if (a === b) { | ||
| return true; | ||
| } | ||
| if ( |
There was a problem hiding this comment.
I think I wrote this, so here's a comment to self:
The a === b and isNan cases can be folded into a single one: if (Object.is(a, b)) { return true; }
tools/test.py
Outdated
| sys.exit(1) | ||
|
|
||
|
|
||
| def main(argv): | ||
| if len(argv) != 2: | ||
| print "Usage: tools/test.py [build dir]" | ||
| build_dir = build_path() |
There was a problem hiding this comment.
I'd find it easier to reason about written like this:
if len(argv) == 2:
build_dir = sys.argv[1]
elif len(argv) == 1:
build_dir = build_path()
else:
print "Usage: tools/test.py [build_dir]"
sys.exit(1)
js/unit_tests.ts
Outdated
| @@ -6,55 +6,12 @@ | |||
| // serving the deno project directory. Try this: | |||
js/unit_tests.ts
Outdated
| @@ -6,55 +6,12 @@ | |||
| // serving the deno project directory. Try this: | |||
| // http-server -p 4545 --cors . | |||
js/testing/util.ts
Outdated
| } | ||
|
|
||
| // tslint:disable-next-line:no-any | ||
| export function equal(c: any, d: any): boolean { |
There was a problem hiding this comment.
This would be a prime use case for the unknown type (new in TypeScript 3).
There was a problem hiding this comment.
I couldn't get it to work immediately but I added a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #434