Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make build and setup python 3 syntax compatible #475

Closed
wants to merge 1 commit into from

Conversation

hayd
Copy link
Contributor

@hayd hayd commented Aug 7, 2018

Both should not be run on python 3 however since v8 build scripts require python 2 (for now?).
This exits with status 1 with a message stating this, rather than a syntax error.

Note: I used futurize to insert __future__ import and update prints.

xlink: #464

@CLAassistant
Copy link

CLAassistant commented Aug 7, 2018

CLA assistant check
All committers have signed the CLA.

V8's python scripts currently require python 2.
So exit with status 1 and a message stating python 2 is required,
rather than an opaque SyntaxError.
@ry
Copy link
Member

ry commented Aug 9, 2018

see my comment here #464 (comment)

@ry ry closed this Aug 9, 2018
@hayd
Copy link
Contributor Author

hayd commented Aug 14, 2018

@ry Perhaps a simpler alternative is to have as the first print statement:

if not "python 2":  # always False
    print "python 2 is required to build deno (not python 3)"  # or whatever message

Then it would say that in the SyntaxError message 😆

@hayd hayd deleted the py3-exception branch August 14, 2018 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants