Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli/js/web/url): Support drive letters in file URLs on Windows #5074

Merged
merged 5 commits into from May 4, 2020
Merged

feat(cli/js/web/url): Support drive letters in file URLs on Windows #5074

merged 5 commits into from May 4, 2020

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented May 4, 2020 •
edited

  • refactor: Parse URLs more sequentially. This makes it easier to change matching behaviour depending on the protocol.
  • fix: Fail when a host isn't given for certain protocols.
  • fix: Convert back-slashes info forward-slashes.

ry
ry approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - ok as long as it matches the web API

@ry ry merged commit 8c509bd into denoland:master May 4, 2020
@nayeemrmn nayeemrmn deleted the url-drive-letters branch May 4, 2020 18:34
SASUKE40 pushed a commit to SASUKE40/deno that referenced this pull request May 7, 2020
@nayeemrmn @SASUKE40
feat(URL): Support drive letters for file URLs on Windows (denoland#5074
77daa65 
)

refactor: Parse URLs more sequentially. This makes it easier to change matching behaviour depending on the protocol.
fix: Fail when a host isn't given for certain protocols.
fix: Convert back-slashes info forward-slashes.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@nayeemrmn
feat(URL): Support drive letters for file URLs on Windows (denoland/d…
f3f2cea 
…eno#5074)

refactor: Parse URLs more sequentially. This makes it easier to change matching behaviour depending on the protocol.
fix: Fail when a host isn't given for certain protocols.
fix: Convert back-slashes info forward-slashes.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@nayeemrmn
feat(URL): Support drive letters for file URLs on Windows (denoland/d…
0e9b431 
…eno#5074)

refactor: Parse URLs more sequentially. This makes it easier to change matching behaviour depending on the protocol.
fix: Fail when a host isn't given for certain protocols.
fix: Convert back-slashes info forward-slashes.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@nayeemrmn @caspervonb
feat(URL): Support drive letters for file URLs on Windows (denoland/d…
33c7b2d 
…eno#5074)

refactor: Parse URLs more sequentially. This makes it easier to change matching behaviour depending on the protocol.
fix: Fail when a host isn't given for certain protocols.
fix: Convert back-slashes info forward-slashes.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@nayeemrmn @caspervonb
feat(URL): Support drive letters for file URLs on Windows (denoland/d…
3debac7 
…eno#5074)

refactor: Parse URLs more sequentially. This makes it easier to change matching behaviour depending on the protocol.
fix: Fail when a host isn't given for certain protocols.
fix: Convert back-slashes info forward-slashes.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@nayeemrmn @caspervonb
feat(URL): Support drive letters for file URLs on Windows (denoland/d…
719158f 
…eno#5074)

refactor: Parse URLs more sequentially. This makes it easier to change matching behaviour depending on the protocol.
fix: Fail when a host isn't given for certain protocols.
fix: Convert back-slashes info forward-slashes.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@nayeemrmn @caspervonb
feat(URL): Support drive letters for file URLs on Windows (denoland/d…
fea024c 
…eno#5074)

refactor: Parse URLs more sequentially. This makes it easier to change matching behaviour depending on the protocol.
fix: Fail when a host isn't given for certain protocols.
fix: Convert back-slashes info forward-slashes.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@nayeemrmn @caspervonb
feat(URL): Support drive letters for file URLs on Windows (denoland/d…
77e25da 
…eno#5074)

refactor: Parse URLs more sequentially. This makes it easier to change matching behaviour depending on the protocol.
fix: Fail when a host isn't given for certain protocols.
fix: Convert back-slashes info forward-slashes.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@nayeemrmn @denobot
feat(URL): Support drive letters for file URLs on Windows (denoland/d…
19592c4 
…eno#5074)

refactor: Parse URLs more sequentially. This makes it easier to change matching behaviour depending on the protocol.
fix: Fail when a host isn't given for certain protocols.
fix: Convert back-slashes info forward-slashes.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@nayeemrmn @denobot
feat(URL): Support drive letters for file URLs on Windows (denoland/d…
64090e8 
…eno#5074)

refactor: Parse URLs more sequentially. This makes it easier to change matching behaviour depending on the protocol.
fix: Fail when a host isn't given for certain protocols.
fix: Convert back-slashes info forward-slashes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nayeemrmn @ry