Revert "Fix definition of URL constructor (#5521)" #5564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, I understood. I hope you remember to include this in v1.1.0. |
bartlomieju
approved these changes
May 18, 2020
This reverts commit 63bc468.
|
It is actually a breaking change with |
Closed
ry
pushed a commit
to ry/deno
that referenced
this pull request
Jul 6, 2020
Attempt 2. See denoland#5521 and denoland#5564.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 21, 2021
…land/deno#5564) This reverts commit 63bc468.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
…land/deno#5564) This reverts commit 63bc468.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
…land/deno#5564) This reverts commit 63bc468.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
…land/deno#5564) This reverts commit 63bc468.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
…land/deno#5564) This reverts commit 63bc468.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
…land/deno#5564) This reverts commit 63bc468.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
…land/deno#5564) This reverts commit 63bc468.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
…land/deno#5564) This reverts commit 63bc468.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Feb 1, 2021
…land/deno#5564) This reverts commit 63bc468.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I landed this change without thinking about it too much. This is an interface change - it actually breaks Oak. We should not land it in the next patch release (1.0.1). I think we should land it in 1.1.0.
This reverts commit 63bc468.
cc @3846masa