-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): json option for "deno info" #6372
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good at first glance.
FYI this is a new feature and thus will have to wait until 1.2.0 lands - which will be July 13.
serde_json::json!(["a", [["b", [["b2", []]]], ["c", []]]]), | ||
deps.to_json() | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me and I believe it's a very useful feature 👍 however I'm not sure about the JSON schema that is currently used, I'm pretty sure we'll iterate on it further.
So I suggest to require --unstable
flag for deno info --json
, so we can change the output before stabilizing this feature.
I'm waiting to test out this feature. Would really appreciate a merge on this. |
I'll try to add the --unstable flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @implicitdef - LGTM
Hello
This PR implements #6260
Examples :
deno info --json
deno info --json https://deno.land/std/http/cookie.ts
Compare to regular output :
deno info https://deno.land/std/http/cookie.ts