feat(std/encoding): add base91 module #6487
Conversation
|
|
I was thought I removed that comment before commiting...
|
Hi @oplik0 - Thanks for the patch. I've never heard of base91 before - interesting. Given that modules in std are intended to stick around forever, may I suggest that you first add this module to deno.land/x and let's see how popular it is? I'm hesitant to add support for an encoding I haven't heard of before. |
Recommended to be added here instead of `std/encoding` (at least for now) by @ry here: denoland/deno#6487 Implementation of [basE91](http://base91.sourceforge.net/) in Deno. Base91 is (as far as I know) most common ascii-only encoding above base85, providing a more efficient - both space-wise and performance-wise - way to store binary data as text. Compared to base64, base91 string should be between 7.7% to 14.3% smaller.
|
Well, I wasn't entirely sure if it fit here too, to be honest. I asked in #dev on discord but didn't get a response so decided to make the PR. After thinking more about it I'd say that you're right, since while it seems to me to be superior to base85 - that encoding is far more popular and therefore more useful, and usually good enough. It's still 25% overhead instead of 33% of base64 (base91 is 23% in the worst case and only 14% in the best). And it's also not available in |
Custom implementation of base91 encoding based on http://base91.sourceforge.net/
It was also heavily influenced by existing base32 and base64 implementations in std/encoding.
Base91 is (as far as I know) most common ascii-only encoding above base85, providing a more efficient - both space-wise and performance-wise - way to store binary data as text. Compared to base64, base91 string should be between 7.7% to 14.3% smaller.