Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(cli/body): improve .arrayBuffer() speed #6669

Merged
merged 1 commit into from
Jul 8, 2020
Merged

perf(cli/body): improve .arrayBuffer() speed #6669

merged 1 commit into from
Jul 8, 2020

Conversation

marcosc90
Copy link
Contributor

@marcosc90 marcosc90 commented Jul 6, 2020 •
edited
Loading

Use content-length header if available to grow the Buffer once to avoid extra allocations & copies.

ry
ry approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks Marcos

@ry ry merged commit e4899b6 into denoland:master Jul 8, 2020
@marcosc90 marcosc90 deleted the body-concatenate-perf branch July 8, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcosc90 @ry