Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refractor(cli + core): unify path normalization utility #6865

Merged
merged 2 commits into from Aug 12, 2020
Merged

refractor(cli + core): unify path normalization utility #6865

merged 2 commits into from Aug 12, 2020

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Jul 24, 2020 •
edited

Removes the code duplication for the utility used by both cli and core. (just reduces extra code)

@bartlomieju
Copy link
Member

The reason for duplication was to not add util/utility module to deno_core, it gives a bad precedent to keep adding more stuff to it.

@littledivy
Copy link
Member Author

littledivy commented Jul 24, 2020 •
edited

@bartlomieju Then should it be exported directly from lib.rs instead of having a utils.rs?

@CLAassistant
Copy link

CLAassistant commented Jul 27, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@bartlomieju bartlomieju requested a review from ry August 11, 2020 09:05
@bartlomieju
Copy link
Member

@ry do you want to land this PR?

ry
ry approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @divy-work

@ry ry merged commit ad4af23 into denoland:master Aug 12, 2020
@littledivy littledivy deleted the refract/normalize-path branch February 27, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@littledivy @bartlomieju @CLAassistant @ry