Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(std/testing): add assertInstanceOf #6874

Closed
wants to merge 1 commit into from
Closed

feat(std/testing): add assertInstanceOf #6874

wants to merge 1 commit into from

Conversation

buttercubz
Copy link

Add an assertInstanceOf function for std/testing/asserts.ts

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bartlomieju
Copy link
Member

Is there prior art for such assert? It's the same amount of chars to type as assert(foo instanceof Person) and it seems it's superfluous.

@buttercubz
Copy link
Author

@bartlomieju should i change it in the test?

@nayeemrmn
Copy link
Collaborator

Duplicate of #5749.

@bartlomieju
Copy link
Member

Thanks for the effot @buttercubz but I'm gonna close this PR without merge, as it is a duplicate of already closed PR as pointed by @nayeemrmn. It's always good to open an issue first and discuss before adding new APIs.

@buttercubz
Copy link
Author

@bartlomieju
Thank you, I'll have it in mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants