Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added TLS serve abilities to file_server #6962

Merged
merged 4 commits into from
Aug 12, 2020
Merged

added TLS serve abilities to file_server #6962

merged 4 commits into from
Aug 12, 2020

Conversation

aricart
Copy link
Contributor

@aricart aricart commented Aug 5, 2020

  • added --cert, --key, --host options to file_server, as file_server is very useful but doesn't provide any TLSoptions.
  • added a basic test for getting a directory and checking that required arguments are provided for TLS.

@aricart
added --cert, --key, --host options to file_server, as file_server is…
cc288eb 
… very useful but doesn't provide any tls options.

added basic test for getting a directory and checking that required arguments are provided for TLS.
@CLAassistant
Copy link

CLAassistant commented Aug 5, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@aricart
Copy link
Contributor Author

aricart commented Aug 5, 2020

realized in hastiness, that I forgot to add a mime type for .mjs.

@bartlomieju bartlomieju added this to the 1.3.0 milestone Aug 11, 2020
lucacasonato
lucacasonato requested changes Aug 11, 2020
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me this looks like three independent changes to the http server:

  1. Allow serving on HTTPS with TLS options
  2. Allow specifying a host to listen on using --host
  3. Adding a media type for .mjs

In the future please do this in multiple pull requests.

std/http/file_server.ts Outdated Show resolved Hide resolved
std/http/file_server.ts Outdated Show resolved Hide resolved
lucacasonato
lucacasonato approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @aricart

@aricart
Copy link
Contributor Author

aricart commented Aug 11, 2020

Thank you @lucacasonato!

@bartlomieju bartlomieju merged commit 91ff910 into denoland:master Aug 12, 2020
@aricart aricart deleted the tls-file-server branch August 12, 2020 12:33
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@aricart
feat(std): added TLS serve abilities to file_server (denoland/deno#6962)
f59f466
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@aricart
feat: added TLS serve abilities to file_server (denoland/deno#6962)
5daa70b
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@aricart @caspervonb
feat: added TLS serve abilities to file_server (denoland/deno#6962)
3dc1e11
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@aricart @caspervonb
feat: added TLS serve abilities to file_server (denoland/deno#6962)
576e8da
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@aricart @caspervonb
feat: added TLS serve abilities to file_server (denoland/deno#6962)
e9b3700
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@aricart @caspervonb
feat: added TLS serve abilities to file_server (denoland/deno#6962)
2743f59
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@aricart @caspervonb
feat: added TLS serve abilities to file_server (denoland/deno#6962)
aa4605d
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@aricart @denobot
feat: added TLS serve abilities to file_server (denoland/deno#6962)
71b250b
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@aricart @denobot
feat: added TLS serve abilities to file_server (denoland/deno#6962)
163ace4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aricart @CLAassistant @lucacasonato @bartlomieju