BREAKING(std/fs): remove writeJson and writeJsonSync #7256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also #7255. Split them for cleaner changelogs. |
caspervonb
force-pushed
the
breaking-std-fs-remove-write-json
branch
from
93c2249
to
84642a3
Compare
|
I was happily using them in my code! I think these functions are a nice addition to Deno. JSON is a very common file type especially in JS/TS projects. Moreover, if the same can be achieved easily with a longer code, it is an argument to keep it in Deno because it is easy to main + it makes people's life easier for handling JSON files. |
|
See #7255 (comment) |
|
I have ported the |
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 21, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes writeJson and writeJsonSync from std/fs entirely as they are fairly peculiar functions and the only ones in the std/fs namespace that deals with file output and they only deal with writing JSON from a text file which is very specialized.
The same can be achieved quite easily with
await Deno.writeTextFile(JSON.stringify(object))andDeno.writeTextFileSync(JSON.stringify(object)).