Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/colors): colors mismatch #7367

Merged
merged 1 commit into from
Sep 8, 2020
Merged

fix(cli/colors): colors mismatch #7367

merged 1 commit into from
Sep 8, 2020

Conversation

EathonYe
Copy link
Contributor

@EathonYe EathonYe commented Sep 6, 2020

fixes #7358
Thanks for review

caspervonb
caspervonb approved these changes Sep 6, 2020
View reviewed changes
Copy link
Contributor

@caspervonb caspervonb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thank you for your contribution! 🎉

bartlomieju
bartlomieju approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @EathonYe

@bartlomieju bartlomieju merged commit 05c46f5 into denoland:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspervonb caspervonb caspervonb approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slight mismatch between crate::colors and rt/colors
3 participants
@EathonYe @caspervonb @bartlomieju