Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): merge CoreIsolate and EsIsolate #7370

Merged
merged 2 commits into from
Sep 6, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Sep 6, 2020

This PR merges EsIsolate into CoreIsolate.

By default CoreIsolate uses NoopModuleLoader that is a placeholder implementation
of ModuleLoader that errors anytime module load is attempted.

A new intializer has been added CoreIsolate::new_with_loader - replaces EsIsolate::new -
it's required to pass ModuleLoader instance.

TODO:

  • bike-shedding - do we want to rename CoreIsolate? Do we want to rename CoreIsolate::new_with_loader()?
  • should we add CoreIsolate::new_with_loader_and_heap_limits? Or maybe add heap_limits as 3rd/4th param to CoreIsolate::new() and CoreIsolate::new_with_loader()?

@ry
Copy link
Member

ry commented Sep 6, 2020

Let’s leave it CoreIsolate for now - to avoid too many changes at once - but I’m very open to changing it.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 803bdd3 into denoland:master Sep 6, 2020
@bartlomieju bartlomieju deleted the merge_isolates branch September 6, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants