Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(unstable): deno run --watch #7382

Merged
merged 14 commits into from
Sep 11, 2020
Merged

feat(unstable): deno run --watch #7382

merged 14 commits into from
Sep 11, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Sep 7, 2020 •
edited
Loading

This PR supersedes #5955.

For the first version we will support only deno run for file watching.

There will be no config - only --watch flag. The runtime will start
watching file for changes based on the loaded module graph.

Caveats:

  • creates new file watcher after each restart
  • doesn't track dynamic import/worker scripts
  • no debounce (most editors already handle that)

@bartlomieju
Copy link
Member Author

Note to self: add @Caesar2011 as co-author before landing

@bartlomieju bartlomieju mentioned this pull request Sep 9, 2020
Closed
@dgpgdev
Copy link

dgpgdev commented Sep 9, 2020

@bartlomieju thank u to keep this feature alive :) 👍

@lucacasonato lucacasonato added this to the 1.4.0 milestone Sep 9, 2020
@Caesar2011
Copy link
Contributor

Thank you for continuing development. I am currently on my master thesis so I had to stop developing...

@bartlomieju bartlomieju changed the title [WIP] deno run --watch feat: deno run --watch Sep 11, 2020
lucacasonato
lucacasonato reviewed Sep 11, 2020
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I tried it locally and it works as expected. Just some nit picks.

cli/file_watcher.rs Outdated Show resolved Hide resolved
cli/flags.rs Show resolved Hide resolved
@bartlomieju
Copy link
Member Author

Screenshot 2020-09-11 at 13 18 42

lucacasonato
lucacasonato approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju mentioned this pull request Sep 11, 2020
Closed
7 tasks
@bartlomieju bartlomieju changed the title feat: deno run --watch feat(unstable): deno run --watch Sep 11, 2020
@bartlomieju
Copy link
Member Author

Add --unstable check before landing

@bartlomieju bartlomieju merged commit a3282aa into denoland:master Sep 11, 2020
@bartlomieju bartlomieju deleted the deno_run_watch branch September 11, 2020 16:19
@Caesar2011
Copy link
Contributor

Awesome!

This was referenced Sep 12, 2020
Closed
Closed
@pedropaulosuzuki pedropaulosuzuki mentioned this pull request Oct 3, 2020
Closed
@ahuggins-nhs ahuggins-nhs mentioned this pull request Mar 8, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

@ry ry Awaiting requested review from ry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bartlomieju @dgpgdev @Caesar2011 @lucacasonato