Use gotham-like state for ops #7385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piscisaureus
reviewed
Sep 7, 2020
piscisaureus
reviewed
Sep 7, 2020
|
Looks good generally. The comment on the "sync op fn" signature is the only serious comment. Also before diving deep into CLI I'd try to figure out the CLI metrics wrapper, or this could turn into a really sour experience in a couple (dozen) hours. |
ry
commented
Sep 7, 2020
|
@piscisaureus Further edits to the interface defined in core. Exposing json_op_sync and json_op_async wrappers rather than having special op registration functions for json ops. OpTable moved to JsRuntime state. deno_core is green, CLI remains unintegrated. |
|
Seems everything is working but plugins... |
piscisaureus
reviewed
Sep 9, 2020
bartlomieju
approved these changes
Sep 9, 2020
|
merged it myself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a concrete state type that can be dynamically added to. This is necessary for op crates.
Rc<RefCell<OpState>>OpRegistry,OpRoutertraitsregister_op(),register_op_json_sync(),register_op_json_async()back to be JsRuntime methodsget_error_class_fnmoved to OpStateStatus: deno_core tests/examples are good (
cargo test -p deno_core). cli hasn't been integrated yet.