Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): response arrayBuffer, blob, text and json null return #7387

Merged
merged 3 commits into from
Sep 8, 2020
Merged

fix(cli): response arrayBuffer, blob, text and json null return #7387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
874b486
fix(cli): response arrayBuffer, blob, text and json null return
caspervonb Sep 7, 2020
884b12f
Assert blob as-well
caspervonb Sep 7, 2020
4030269
Bump CI
caspervonb Sep 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/rt/24_body.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
const enc = new TextEncoder();
return enc.encode(bodySource.toString()).buffer;
} else if (!bodySource) {
return null;
return new ArrayBuffer(0);
}
throw new Error(
`Body type not implemented: ${bodySource.constructor.name}`,
Expand Down
10 changes: 10 additions & 0 deletions cli/tests/unit/fetch_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,6 +738,16 @@ unitTest(function responseRedirect(): void {
assertEquals(redir.type, "default");
});

unitTest(async function responseWithoutBody(): Promise<void> {
const response = new Response();
assertEquals(await response.arrayBuffer(), new ArrayBuffer(0));
assertEquals(await response.blob(), new Blob([]));
assertEquals(await response.text(), "");
await assertThrowsAsync(async () => {
await response.json();
});
});

unitTest({ perms: { net: true } }, async function fetchBodyReadTwice(): Promise<
void
> {
Expand Down