Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): JsRuntime initialization #7415

Merged
merged 12 commits into from
Sep 11, 2020
Merged

refactor(core): JsRuntime initialization #7415

merged 12 commits into from
Sep 11, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Sep 10, 2020 •
edited
Loading

Removes:

  • deno_core::StartupData
  • deno_core::Script
  • deno_core::OwnedScript

Changes to JsRuntime:

  • remove new_with_loader()
  • remove with_heap_limits()
  • rename IsolateOptions to RuntimeOptions and make public
  • JsRuntime::new() takes RuntimeOptions as a single param

Closes #7396
Closes #7386

@bartlomieju bartlomieju changed the title [WIP] refactor(core): Refactor Runtime [WIP] refactor(core): Runtime initialization Sep 10, 2020
@bartlomieju bartlomieju changed the title [WIP] refactor(core): Runtime initialization refactor(core): Runtime initialization Sep 10, 2020
@bartlomieju bartlomieju requested review from ry and piscisaureus and removed request for ry September 10, 2020 18:33
@bartlomieju bartlomieju changed the title refactor(core): Runtime initialization refactor(core): JsRuntime initialization Sep 10, 2020
ry
ry approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM good clean up

@bartlomieju bartlomieju merged commit 0d1f626 into denoland:master Sep 11, 2020
@bartlomieju bartlomieju deleted the refactor_runtime branch September 11, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@piscisaureus piscisaureus Awaiting requested review from piscisaureus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor deno_core::JsRuntime initializers deno_core: invalid JS code causes panic
2 participants
@bartlomieju @ry