Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rusty_v8 0.10.0 / V8 8.7.75 #7429

Merged
merged 2 commits into from Sep 13, 2020

Conversation

piscisaureus
Copy link
Member

No description provided.

@piscisaureus
Copy link
Member Author

This is red because 'ts_decorators' failed, but that test is unsound (it has for example never passed for me locally).

Proposal is to land this PR and if you care enough we can delete the ts_decorators test.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with disabling the test and landing this - but it's confusing why would upgrading rusty_v8 effect this one random test...

@bartlomieju
Copy link
Member

What's even more strange is that I get proper output on Mac and test passes. It seems class name is not printed on Linux 🙄 I guess we can disable this test for know, but this situation looks like V8 bug.

@piscisaureus
Copy link
Member Author

My suspicion is that something gets compiled, then written to cache, then restored from cache, and there's a race condition in all this.

A V8 bug is certainly not out of the question but the fact that it happens on some systems only (and older versions of V8 too, just not on CI) makes me think that's an unlikely explanation.

@bartlomieju
Copy link
Member

My suspicion is that something gets compiled, then written to cache, then restored from cache, and there's a race condition in all this.

I think that's unlikely, ts_decorators.ts is used only in this single test.

Should we land this PR before 1.4.0?

@bartlomieju bartlomieju merged commit bf70442 into denoland:master Sep 13, 2020
@bartlomieju
Copy link
Member

@piscisaureus https://v8.dev/blog/v8-release-86#small-normative-changes <--- this might be the reason ts_decorators broke during the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants