Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fs] Enable mode for mkdir on *nix #746

Merged
merged 3 commits into from Sep 14, 2018
Merged

[fs] Enable mode for mkdir on *nix #746

merged 3 commits into from Sep 14, 2018

Conversation

kevinkassimo
Copy link
Contributor

  • Enable mode for mkdir on *nix.

@kevinkassimo kevinkassimo force-pushed the fs/mkdir-mode branch 2 times, most recently from ff9ae61 to c56f7ef Compare September 14, 2018 04:09
@kevinkassimo
Copy link
Contributor Author

This PR seems repeatedly failing/erroring for non test failure reasons (the 2 travis tasks fails alternately...)

ry
ry approved these changes Sep 14, 2018
View reviewed changes
Copy link
Member

@ry ry left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@piscisaureus any comments regarding windows ?

@piscisaureus
Copy link
Member

No comments w.r.t. windows.
Mode cannot be meaningfully implemented there.

@ry ry merged commit 662e57b into denoland:master Sep 14, 2018
@ry
Copy link
Member

ry commented Sep 14, 2018

Thanks Kevin!

ry added a commit to ry/deno that referenced this pull request Sep 22, 2018
@ry
v0.1.5
e083bd9 
- Add atob() btoa() denoland#776
- Add deno.arch deno.platform denoland#773
- Add deno.symlink() and deno.symlinkSync() denoland#742
- Add deno.mkdir() and deno.mkdirSync() denoland#746
- Add deno.makeTempDir() denoland#740
- Improvements to FileInfo interface denoland#765, denoland#761
- Add fetch.blob()
- Upgrade V8 to 7.0.276.15
- Upgrade Rust crates
@ry ry mentioned this pull request Sep 22, 2018
Merged
ry added a commit that referenced this pull request Sep 22, 2018
@ry
v0.1.5
8e958d3 
- Add atob() btoa() #776
- Add deno.arch deno.platform #773
- Add deno.symlink() and deno.symlinkSync() #742
- Add deno.mkdir() and deno.mkdirSync() #746
- Add deno.makeTempDir() #740
- Improvements to FileInfo interface #765, #761
- Add fetch.blob()
- Upgrade V8 to 7.0.276.15
- Upgrade Rust crates
@kevinkassimo kevinkassimo deleted the fs/mkdir-mode branch December 27, 2019 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevinkassimo @piscisaureus @ry