Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use Symbol.for instead of Symbol for Deno.customInspect #7537

Merged
merged 4 commits into from Sep 17, 2020
Merged

refactor: use Symbol.for instead of Symbol for Deno.customInspect #7537

merged 4 commits into from Sep 17, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Sep 17, 2020 •
edited

Closes #7536

@bartlomieju bartlomieju changed the title [WIP] refactor: move console to op_crates/web refactor: use Symbol.for instead of Symbol for Deno.customInspect Sep 17, 2020
@bartlomieju bartlomieju mentioned this pull request Sep 17, 2020
Merged
@bartlomieju bartlomieju requested a review from ry September 17, 2020 16:16
ry
ry approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit c307e3e into denoland:master Sep 17, 2020
vitormmatos pushed a commit to vitormmatos/deno that referenced this pull request Sep 21, 2020
@bartlomieju
refactor: use Symbol.for instead of Symbol in cli/rt/ (denoland#7537)
7a8ff3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor "Deno.customInspect" symbol
2 participants
@bartlomieju @ry