Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] refactor: Flags passing #7743

Closed
wants to merge 2 commits into from
Closed

[WIP] refactor: Flags passing #7743

wants to merge 2 commits into from

Conversation

bartlomieju
Copy link
Member

No description provided.

@kitsonk
Copy link
Contributor

kitsonk commented Sep 28, 2020

I know you are keen on trying to address some of this stuff, but it is going to be hard to work on #7225 if we have other refactors going on at the same time. This gets into exactly the worry I had about re-base hell.

@bartlomieju
Copy link
Member Author

I know you are keen on trying to address some of this stuff, but it is going to be hard to work on #7225 if we have other refactors going on at the same time. This gets into exactly the worry I had about re-base hell.

@kitsonk sure, I just close this one. Those issues can be addressed later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartlomieju @kitsonk