-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(unstable): add Deno.systemCpuInfo() #7774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eliassjogreen sorry for slow review, only one small thing to fix and we can land it for 1.5.0
@eliassjogreen I'd be interested in landing this PR for tomorrow's release, but the CI is still red. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you @eliassjogreen
Related to #3802, I decided to not implement a node compatible
cpus
function due to thesys_info
crate not fully supporting all the functionality needed (cpu model and times in different modes).