-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli/console): inspect with colors regardless of Deno.noColor #7778
feat(cli/console): inspect with colors regardless of Deno.noColor #7778
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favour of this change. It matches Node. Only APIs that write to the terminal should take into account NO_COLOR
, not programmatic ones. We should consider it for std/fmt/colors.ts
.
Co-authored-by: Nayeem Rahman <nayeemrmn99@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…olor (denoland#7778)" This reverts commit f75bd89.
This PR adds the ability for users to inspect items stylized with ANSI colors regardless of the value of
Deno.noColor
- for example,Considerations:
Deno.noColor
gets initted, should we assume the user accepts colors in their terminal?(currently as it is,
colors.maybeColor
assumes that terminal colors shouldn't be present)