feat(cli/repl): add regex based syntax highlighter #7811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a simple regex replace based highlighter to the repl editor.
|
Example:
|
nayeemrmn
reviewed
Oct 3, 2020
bartlomieju
reviewed
Oct 4, 2020
bartlomieju
approved these changes
Oct 11, 2020
There was a problem hiding this comment.
LGTM, thank you @caspervonb for this feature, it's extremely useful. I also like how simple the implementation is.
I'd be great to have a way to test that, but it's the same problem as with all integration tests.
| (?P<boolean>\b(?:true|false)\b) | | ||
| (?P<null>\b(?:null)\b) | | ||
| (?P<undefined>\b(?:undefined)\b) | | ||
| (?P<keyword>\b(?:await|async|var|let|for|if|else|in|of|class|const|function|yield|return|with|case|break|switch|import|export|new|while|do|throw|catch)\b) | |
There was a problem hiding this comment.
Indeed, treating it as identifier (no color) for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple regex replace based highlighter to the repl editor.
Overall it tries to match the color palette of
Deno.inspect.Closes #1928