Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the WIP for the way of bundling. It does the following:
tsc
calledts_checker
which does a type check only.Like currently,
deno bundle
does a type check, but it now supports the incremental build for bundles, which make subsequent type checks faster. It also supportsdeno bundle --no-check
as well. In all cases it usesswc_bundler
which emits a single file "flat" ES module.Things going on:
deno bundle
with swc.deno bundle
, where if a dynamic import could be statically identified, it would be included in the bundle. This isn't a big deal with absolute URLs, but if users are importing something relative and locally, then this becomes a bit of an issue, as it doesn't make the bundle very portable. We might want to consider ways of dealing with this (like maybe warning on dynamic import). Also, this is a significant change in behaviour, and some could argue a breaking change.