Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(op_crate/web): Add padding on URLSearchParam #7905

Merged
merged 1 commit into from
Oct 10, 2020
Merged

fix(op_crate/web): Add padding on URLSearchParam #7905

merged 1 commit into from
Oct 10, 2020

Conversation

lala7573
Copy link
Contributor

@lala7573 lala7573 commented Oct 9, 2020

fixes: #7888

@CLAassistant
Copy link

CLAassistant commented Oct 9, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lala7573 lala7573 changed the title fix(op_crate/web): Add padding on URLSearchParam (denoland#7888) fix(op_crate/web): Add padding on URLSearchParam Oct 9, 2020
kitsonk
kitsonk approved these changes Oct 10, 2020
View reviewed changes
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitsonk kitsonk merged commit 782e6a2 into denoland:master Oct 10, 2020
iykekings pushed a commit to iykekings/deno that referenced this pull request Oct 10, 2020
@lala7573 @iykekings
fix(op_crate/web): add padding on URLSearchParam (denoland#7905)
57496b8 
Fixes denoland#7888
@lala7573 lala7573 deleted the issues/7888 branch November 11, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsonk kitsonk kitsonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URLSearchParams: \n not encoded correctly
3 participants
@lala7573 @CLAassistant @kitsonk